This repository has been archived by the owner on Mar 26, 2021. It is now read-only.
Issue 95 -add support for filename as parameter #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this PR solves Issue #95 , Add support for using the strest test filename as a parameter in the request .
I was a little bit more complicated than stated in the issue , due to the fact that the testObject.relativepath is not the file name , it's just the path to the file .
1.I have added fileName property on parse file object at yaml-parse.ts, and updated the schema .
2.Passes the file name to the computeRequestObject that uses the common practice of nunjucksEnv addGlobal to replace the Filname() string with the fileName
3.updated the readme
I have 2 Notes
1.I am removing the strest suffix from the file name - see the computeRequestObject function .
2.we need to consider using nodejs path.parse(filePath)
to get all the file parts .. (folder / root )
see this line in yaml-parse.ts
const {name:fileName} = path.parse(filePath);